Skip to content

[scraperhelper] Use {record} unit for log and profile record metrics - #15730

Merged
mx-psi merged 2 commits into
open-telemetry:mainfrom
mx-psi:worktree-scraper-metric-units
Aug 5, 2026
Merged

[scraperhelper] Use {record} unit for log and profile record metrics#15730
mx-psi merged 2 commits into
open-telemetry:mainfrom
mx-psi:worktree-scraper-metric-units

Conversation

@mx-psi

@mx-psi mx-psi commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Correct units for scraper metrics.

Authorship

  • I, a human, wrote this pull request description myself.

The scraped/errored log record and profile record metrics were labeled
{datapoint}. receiverhelper and exporterhelper use {record} for log
records.

Assisted-by: Claude Opus 5
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.07%. Comparing base (8d9d794) to head (70d79b4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15730   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         732      732           
  Lines       48511    48511           
=======================================
  Hits        44181    44181           
  Misses       3011     3011           
  Partials     1319     1319           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .chloggen/scraperhelper-log-record-unit.yaml Outdated
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@mx-psi
mx-psi marked this pull request as ready for review August 5, 2026 11:23
@mx-psi
mx-psi requested a review from a team as a code owner August 5, 2026 11:23
@mx-psi
mx-psi requested a review from jmacd August 5, 2026 11:23
@mx-psi
mx-psi added this pull request to the merge queue Aug 5, 2026
Merged via the queue into open-telemetry:main with commit ef342d3 Aug 5, 2026
78 of 81 checks passed
@mx-psi
mx-psi deleted the worktree-scraper-metric-units branch August 5, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants